Re: [PATCH v3] x86/sgx: Free backing memory after faulting the enclave page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 24, 2022 at 09:17:32AM -0800, Dave Hansen wrote:
> On 1/12/22 22:08, Reinette Chatre wrote:
> > ------------[ cut here ]------------
> > ELDU returned 9 (0x9)
> > WARNING: CPU: 6 PID: 2470 at arch/x86/kernel/cpu/sgx/encl.c:77 sgx_encl_eldu+0x37c/0x3f0
> 
> Could we flesh out that error message, please?
> 
> That "return" is a code from "Information and Error Codes" in the SGX SDM
> chapter.  It's also spelled out in 'enum sgx_return_code'.  So, at least,
> this should probably say:
> 
> 	ELDU sgx_return_code: 9 (0x9)
> 
> *That* is at least greppable.

Yes, I'm all for adding sgx_ prefix to everything but should it rather
be "sgx: ELDU ..." like most of everything else?

/Jarkko



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux