Re: [PATCH] x86/sgx: Fix NULL pointer dereference on non-SGX systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/17/21 4:07 PM, Greg KH wrote:
>> +static umode_t arch_node_attr_is_visible(struct kobject * kobj,
>> +		struct attribute * attr, int idx)
>> +{
>> +	/* Make all x86/ attributes invisible when SGX is not initialized: */
>> +	return !nodes_empty(sgx_numa_mask);
> That's a very odd umode_t return value :)
> 
> Did you test this?  What was the mode of the sysfs file that is created?

Hah, I tested the "return 0" side of it.  That half works great!

The "return 1" side, obviously not.  I'll fix that up before sending it
out for real.



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux