On Wed, Dec 01, 2021 at 11:23:05AM -0800, Reinette Chatre wrote: > The SGX reclaimer removes page table entries pointing to pages that are > moved to swap. SGX2 enables changes to pages belonging to an initialized > enclave, for example changing page permissions. Supporting SGX2 requires > this ability to remove page table entries that is available in the > SGX reclaimer code. Missing: why SGX2 requirest this? > Factor out the code removing page table entries to a separate function, > fixing accuracy of comments in the process, and make it available to other > areas within the SGX code. > > Since the code will no longer be unique to the reclaimer it is relocated > to be with the rest of the enclave code in encl.c interacting with the > page table. This last paragraph should be removed. It can be seen from the code change and diffstat. /Jarkko
