On Wed, 2021-11-03 at 23:49 +0200, Jarkko Sakkinen wrote: > On Wed, 2021-11-03 at 09:22 +0100, Greg Kroah-Hartman wrote: > > That's not the proper thing to do here at all, these values should be > > part of the device structure that this attribute lives on, in order to > > properly handle all of these reference counting and locking issues > > automatically. > > The attribute group is part of the device structure, so in that sense > it is already like this. And I think that all NUMA node specific data > (most of which is unrelated to device sysfs) is best kept in the private > struct. If you are concerned that the SGX driver might go away when NUMA code calls it, I can address that concern too. The memory management code if arch/x86/kernel/cpu/sgx is not associated with the user space facing driver. E.g. you can use memory manager with KVM without having the driver even enabled in the kernel. This include the numa code in the SGX subsystem. It's life-cycle is the same as the power-cycle. It is guaranteed that any possible time during the power cycle, when that sysfs callback is called, all the data is valid. That's why it is safe to be part of the attribute groups of the NUMA device. /Jarkko
