On Sat, Oct 23, 2021 at 04:02:48AM +0300, Jarkko Sakkinen wrote: > On Mon, 2021-10-18 at 16:35 +0200, Greg Kroah-Hartman wrote: > > > + ret = sysfs_create_group(&dev->kobj, &sgx_node_attr_group); > > > > A huge hint, if a driver has to call a sysfs_* call, something is wrong. > > > > Something is wrong here. > > > > Why are you messing around with a kobject? This is a device, that you > > control, you can just set the default attribute group for it and then > > the driver core will add and remove the sysfs group at the proper time, > > in the proper way. Right now you are racing userspace and loosing. > > > > Use the default group list, that is what it is there for. > > I used sysfs_create_group() because node_devices is not owned by SGX > code. It is managed in drivers/base/node.c, and also initialized before > SGX. Then that is broken, please do not use that device as your code does not "own" it. Or fix the logic to be initialized earlier. thanks, greg k-h
