On 9/15/21 1:30 PM, Reinette Chatre wrote: > This series consists out of outstanding SGX selftests changes, rebased > and gathered in a single series that is more easily merged for testing > and development, and a few more changes added to expand the existing tests. One other high-level thing we should probably mention: Building and running enclaves is a pain. It's traditionally required a big SDK from Intel or a big software stack from *somebody* else. This adds features like threads to the SGX selftest which are traditionally implemented in that big software stack. This is a *good* thing since it helps test SGX kernel support with only code from the kernel tree. This is similar to what we did with MPX, which also typically required a big toolchain outside of the kernel. Despite MPX's demise, I think this approach worked well, and I'm happy to see it replicated here. Feel free to add my ack on the real (non-stub) patches in the series: Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
