> > > -/* The free page list lock protected variables prepend the lock. */ > > > +/* The number of usable EPC pages in the system. */ > > > +unsigned long sgx_nr_all_pages; > > > + > > > +/* The number of free EPC pages in all nodes. */ > > > static unsigned long sgx_nr_free_pages; > > > > > > /* Nodes with one or more EPC sections. */ > > > @@ -656,6 +659,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size, > > > list_add_tail(§ion->pages[i].list, &sgx_dirty_page_list); > > > } > > > > > > + sgx_nr_all_pages += nr_pages; > > > + > > > > EPC sections can be freed again in sgx_init() after they are successfully > > initialized, when any further initialization fails (i.e. when fails to create > > ksgxd, or fails to register /dev/sgx_provision). In which case, I think > > sgx_nr_all_pages should also be cleared. But current sgx_init() seems doesn't > > reset it. Do you need to fix that too? > > sgx_nr_all_pages tells just the total pages in the system, i.e. it's a constant. > > Maybe a rename to "sgx_nr_total_pages" would be a good idea? Would match with > the meminfo field better too. I don't have preference on name. I just think if there's no actual user of EPC (when both driver and KVM SGX cannot be enabled), it's pointless to print number of EPC pages. > > > > > > return true; > > > } > > > > > > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > > > index ad8a5c586a35..82bb09c298de 100644 > > > --- a/arch/x86/mm/pat/set_memory.c > > > +++ b/arch/x86/mm/pat/set_memory.c > > > @@ -29,6 +29,7 @@ > > > #include <asm/proto.h> > > > #include <asm/memtype.h> > > > #include <asm/set_memory.h> > > > +#include <asm/sgx.h> > > > > How about only include <asm/sgx.h> when CONFIG_X86_SGX is on, then you don't > > have to do #ifdef CONFIG_X86_SGX changes to sgx.h? > > Why do it that way instead of doing it once in sgx.h for every site that wants > to include the file? Just my preference. You only need sgx_nr_all_pages here, while <asm/sgx.h> has bunch of others such as SGX data structures. It seems it's not worth to include <asm/sgx.h> directly.
