Re: [PATCH v3 2/2] x86/sgx: Add SGX_MemTotal to /proc/meminfo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/26/21 9:17 AM, Jarkko Sakkinen wrote:
>> I would prefer to see this listed in Documentation/filesystems/proc.rst
>> as an optional field, depending on CONFIG_X86_SGX.
>> Or at least put a reference in proc.rst to this doc file and its
>> supplemental fields.
>>
>> thanks.
> I *can* put it there but I did have reason not to, i.e. these attributes
> are neither there:
> 
> DirectMap4k:     3930904 kB
> DirectMap2M:    29440000 kB
> DirectMap1G:     1048576 kB
> 
> And they are implemented in arch specific code.
> 
> Actually they are undocumented, e.g.
> 
> $ git grep DirectMap4k
> arch/powerpc/mm/book3s64/pgtable.c:     seq_printf(m, "DirectMap4k:    %8lu kB\n",
> arch/s390/mm/pageattr.c:        seq_printf(m, "DirectMap4k:    %8lu kB\n",
> arch/x86/mm/pat/set_memory.c:   seq_printf(m, "DirectMap4k:    %8lu kB\n",

Yeah, we need to add some arch-specific sections to the documentation.
That *could* just be a reference over to a new file:

	Documentation/x86/meminfo.rst

along with whatever other arches provide their own fields too.



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux