On 4/1/21 1:22 AM, Jarkko Sakkinen wrote: > On Wed, Mar 31, 2021 at 02:18:50PM +0200, Raoul Strackx wrote: >> The current sgx driver can only launch enclaves that always measure 4K >> pages. That may not necessarily be the case. This patch adds an ioctl to >> enable users to add the enclave measurement per 256 byte. > > Please run scripts/checkpatch.pl. You cannot write a long description in > a single line > > Also please write 'SGX' instead of 'sgx' I've made the requested changes locally and will include them in the next version of the patch. I'm still very new to the Linux patch process. Thanks for understanding. > I do understand the code change but also the current ioctl measure per 256 > byte the full page. What I'm saying that the long description does not > contain any information what this patch adds to that. It neither makes the > case why it makes sense to have enclaves where full pages are not measured. Yes the description was too succinct. Dave Hansen had a similar comment. Let me reply to this in the email thread with all appropriate addressed people and mailing lists. Regards, Raoul
