On 2/2/21 9:56 AM, Paolo Bonzini wrote: > On 01/02/21 01:01, Kai Huang wrote: >>>> I think we can remove comment for SGX1, since it is basically SGX. >>>> >>>> For SGX2, how about below? >>>> >>>> /* SGX Enclave Dynamic Memory Management */ >>> (EDMM) >> Does EDMM obvious to everyone, instead of explicitly saying Enclave >> Dynamic >> Memory Management? >> >> Also do you think we need a comment for SGX1 bit? I can add /* Basic >> SGX */, >> but I am not sure whether it is required. > > Yes, please use > > /* "" Basic SGX */ > /* "" SGX Enclave Dynamic Memory Mgmt */ Do you actually want to suppress these from /proc/cpuinfo with the ""?