On Fri, Sep 25, 2020 at 10:28:07AM +0200, Borislav Petkov wrote: > > > I can see why you would write "TCS" though - there's a thread control > > > structure thing too in that patch. > > > > Renamed. > > See Sean's reply. I did not get Sean's reply, and neither can find it from lore: https://lore.kernel.org/linux-sgx/20200915112842.897265-1-jarkko.sakkinen@xxxxxxxxxxxxxxx/T/#t > > * typedef sgx_enclave_exit_handler_t - Exit handler function accepted by > > * __vdso_sgx_enter_enclave() > > * @rdi: RDI snapshot > > * @rsi: RSI snapshot > > * @rdx: RDX snapshot > > * @rsp: RSP snapshot (untrusted stack) > > * @r8: R8 snapshot > > * @r9: R9 snapshot > > I'd say here: > > "The registers' content is the snapshot made at enclave exit." I'd make that a description and take away individual parameter descriptions. Is that fine? > > Also, I renamed 'r' as 'run' in some places. > > > > End result: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-sgx.git/tree/arch/x86/include/uapi/asm/sgx.h > > > > I'm wondering this sentence: > > > > "The calling convention is custom and does not follow System V x86-64 ABI." > > Yeah, I was wondering what that meant too. I'll refine that one based on my own and Jethro's feedback. > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette /Jarkko
