On Fri, Sep 25, 2020 at 09:51:04AM +0200, Borislav Petkov wrote: > On Thu, Sep 24, 2020 at 11:38:59PM +0300, Jarkko Sakkinen wrote: > > I assume this is a rethorical question > > Of course - our text should not be write-only. > > > and I notice what I suggested > > looks as bad as my earlier commit message :-) > > > > So, I gave it some thought that and decided to "open code" the paragraph > > as > > > > "Add sgx_vma_access() function that implements 'access' virtual function > > of struct vm_operations_struct. Use formentioned leaf instructions to > > "aforementioned" Ugh, that the was worst spelling I've done for a while. > > achieve read and write primitives for the enclave memory." > > I'd say "to provide read and write access to enclave memory." Sound better yes, thanks. > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette Updated the commit message accordingly. I also rebased now to x86 tip (and yes, merge conflicts were trivial to sort out). /Jarkko
