On Fri, Sep 04, 2020 at 03:44:33AM -0700, Sean Christopherson wrote: > Rework __vdso_sgx_enter_enclave() to use a struct to hold the input and > output params. In the new struct, add an opaque "user_data" that can be > used to pass context across the vDSO, an explicit "exit_reason" to avoid > overloading the return value, and a "flags" field to provide a path for > future extensions. > > Moving the params into a struct will also make it less painful to use > dedicated exit reasons values in a future patch. > > Cc: Nathaniel McCallum <npmccallum@xxxxxxxxxx> > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> I like this a lot. Everything is now so much better tied together. If I understood the change correctly this solution also addreses my concerns of eBPF because 'flags' allows to change representation what handler means (later on, if we ever want). Acked-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> /Jarkko