Re: [RFC PATCH 2/4] x86/vdso: x86/sgx: Rework __vdso_sgx_enter_enclave() API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/17/2020 9:24 PM, Sean Christopherson wrote:
Rework __vdso_sgx_enter_enclave() to use a struct to hold the input and
output params.  In the new struct, add an opaque "user_data" that can be
used to pass context across the vDSO, and an explicit "exit_reason" to
avoid overloading the return value.
In order to pass additional parameters to the exit handler, the exinfo
structure could be embedded in a user-defined structure while the handler could pick it up using "container_of" macro. IMO the original interface was neat and suffcient, and we are over-engineering it.

Moving the params into a struct will also make it less painful to use
dedicated exit reasons, and to support exiting on interrupts in future
patches.

My apology for not following discussion lately. What did you mean by "dedicated exit reasons" and why was it "painful"? According to another thread, I guess we wouldn't have "exiting on interrupts".



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux