On Thu, Jun 25, 2020 at 10:25:39PM +0200, Borislav Petkov wrote: > On Thu, Jun 25, 2020 at 11:21:48PM +0300, Jarkko Sakkinen wrote: > > Would be probably easier to review also this way because the commit kind > > of rationalizes why things exist. > > > > What do you think? > > Sounds like a plan but you can do this for the next version - no need to > do it now. I'll try to review this way, per ioctl as I said in my mail > to Sean. OK, sure I won't rush with a new version :-) The code has been reworked so many times that it is somewhat easy to make such split and I think it is one measure that an implementation is somewhat sound when parts of functionality build up cleanly on top of each other. /Jarkko
