On Wed, Mar 18, 2020 at 05:50:47PM +0200, Jarkko Sakkinen wrote: > > > + /* > > > + * DO NOT call synchronize_srcu()! When this is called via dup_mmap(), > > > + * mmap_sem is held for write in both the old mm and new mm, and the > > > + * reclaimer may be holding srcu for read while waiting on down_read() > > > + * for the old mm's mmap_sem, i.e. synchronizing will deadlock. > > > + * Incrementing the list version ensures readers that must not race > > > + * with a mm being added will see the updated list. > > > + */ > > For this comment, please completely remove it. We either call something > or do not call it. We do !call anything. Was meaning to say that we do not !call anything. /Jarkko
