On Tue, Nov 05, 2019 at 02:52:23PM -0800, Sean Christopherson wrote: > On Tue, Nov 05, 2019 at 01:20:56PM +0200, Jarkko Sakkinen wrote: > > Add @count write the number of bytes added as there is not any good reason > > to overwrite input parameters. > > I disagree, overwriting the params means userspace doesn't need to adjust > the values to restart the ioctl(). Ditto for printing out the failing > address if the ioctl() fails. There is three redundant updates. At least only @length must be updated in order to remove this glitch. As far as overwriting goes, it should be only done when there is requiring to do that. /Jarkko
