On Fri, Oct 18, 2019 at 01:12:52PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 16, 2019 at 08:03:26PM -0700, Sean Christopherson wrote: > > The bulk of this series is comprised of the selftest portion of the vDSO > > cleanup[*]. The big difference from the full vDSO series is to reuse as > > much of the existing selftest code as possible. There is still a bit of > > homebrew code in defining the low level assertion macro, but much less so > > than in the previous from-scratch version. > > > > Cc'd Andy, who also happens to be a reviewer for the harness code, on the > > off chance he has bandwidth to weigh in. > > > > Tagged for_v2? to make it clear that this doesn't need to be rushed into > > v23. > > No need for harness right now. Open coded tests are better for initial > upstreaming. Macros make code more productive to write but harder to read and debug. With only maybe three tests the cost of using them does not pay. /Jarkko
