On Tue, Oct 15, 2019 at 01:25:55PM +0300, Jarkko Sakkinen wrote: > On Tue, Oct 15, 2019 at 01:24:08PM +0300, Jarkko Sakkinen wrote: > > On Tue, Oct 15, 2019 at 01:16:35PM +0300, Jarkko Sakkinen wrote: > > > On Mon, Oct 07, 2019 at 09:46:07PM -0700, Sean Christopherson wrote: > > > > Use the recently added assertion framework to report errors and exit > > > > instead of propagating the error back up the stack. Using assertions > > > > reduces code and provides more detailed error messages, and has no > > > > downsides as all errors lead to exit(1) anyways, i.e. an assertion > > > > isn't blocking forward progress. > > > > > > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > > > > > I'm also dropping all of this. Was too hazy with it because of rush last > > > week. > > > > > > You shoud use EXCEPT_* macros instead of your home baked ones: > > > > > > https://www.kernel.org/doc/html/v4.15/dev-tools/kselftest.html > > > > > > I don't know what you are talking about in this commit message. > > > "Recently added" tells me absolutely nothing. All I see that you > > > are adding your own ad hoc crap. > > > > E.g. > > > > 1. WTH the new thing is. > > 2. Why is it overriding the macros already defined for kselftest > > (see the documentation). > > 3. Before vDSO commits please provide a patch set that does the > > migration with clear explanation what is going on. > > See kselftest_harness.h. For me this all seems like unnecessary stuff done just before patch set release. It is no in anyway necessary for v23 or even for merging SGX to mainline. You seriously cannot stuff like this being merged quickly. It will take a number of days to discuss all this through. My mistake was to merge it before enough consideration. Sometimes it is better just to do the *necessary*. Especially when it is time to release something (e.g. just the minimal changes for vDSO stuff). I replaced all of this with v22 selftest and I'm in the process of adding EENTER call path and splitting that to two commits. /Jarkko
