On Wed, Oct 09, 2019 at 12:10:03PM -0700, Sean Christopherson wrote: > > >+ > > >+ /* Clear RFLAGS.DF per x86_64 ABI */ > > >+ cld > > >+ > > >+ /* Load the callback pointer to %rax and invoke it via retpoline. */ > > >+ mov 0x20(%rbp), %rax > > > > Per X86_64 ABI, %rsp shall be 16 bytes aligned before "call". But %rsp here > > doesn't look aligned properly. > > Argh, I probably botched it back in patch 02/16 too. I'll see if I can > add a check to verify %rsp alignment in the selftest, verifying via code > inspection is bound to be error prone. Added a selftest, stack is indeed not properly aligned.
