On Mon, Oct 07, 2019 at 09:13:34PM -0700, Sean Christopherson wrote: > WARN if EREMOVE fails when destroying an enclave. sgx_encl_release() > uses the non-WARN __sgx_free_page() when freeing pages as some pages may > be in the process of being reclaimed, i.e. are owned by the reclaimer. > But EREMOVE should never fail as sgx_encl_destroy() is only called when > the enclave cannot have active threads, e.g. prior to EINIT and when the > enclave is being released. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> For me this concludes that I will manually convert all the call sites to use __sgx_free_page() and add appropriate warnings. I agree with Borislav's conclusions here. /Jarkko
