On Wed, Sep 25, 2019 at 05:10:58PM +0300, Jarkko Sakkinen wrote: > On Wed, Sep 25, 2019 at 05:09:03PM +0300, Jarkko Sakkinen wrote: > > > > [1] Intel SDM: 38.1.4 Intel SGX Launch Control Configuration > > > > > > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > > > Co-developed-by: Haim Cohen <haim.cohen@xxxxxxxxx> > > > > Signed-off-by: Haim Cohen <haim.cohen@xxxxxxxxx> > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > > > > > > This time checkpatch is right: > > > > > > WARNING: Missing Signed-off-by: line by nominal patch author 'Kai Huang <kai.huang@xxxxxxxxxxxxxxx>' > > > > > > And looking at the SOB chain, sounds like people need to make up their > > > mind about authorship... > > > > I'll make myself the sole author for this one as 98% of the effort in > > this patch is really the commit message, which I rewrote for v22, and 2% > > are the code changes (mechanical, peek at SDM). This patch was squashed > > from three patches, all like one line changes, and Kai was author of one > > of them. > > > > The next version will thus have only my SOB and author information will > > be changed. I doubt anyone will complain if I do that. > > I'll take the same action also for "x86/cpufeatures: x86/msr: Add Intel > SGX hardware bits" I put to both: Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> Co-developed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> And changed author to me. /Jarkko