On Thu, Aug 29, 2019 at 04:09:29PM +0300, Jarkko Sakkinen wrote:
> On Tue, Aug 27, 2019 at 12:27:13PM -0700, Sean Christopherson wrote:
> > @@ -77,7 +78,7 @@ static int sgx_release(struct inode *inode, struct file *file)
> > };
> >
> > mutex_lock(&encl->lock);
> > - encl->flags |= SGX_ENCL_DEAD;
> > + atomic_or(SGX_ENCL_DEAD, &encl->flags);
> > mutex_unlock(&encl->lock);
>
> Had a couple of checkpatch.pl errors (not a biggie, just a remark).
Regarding the checkpatch warnings, I intentionally ignored these:
WARNING: line over 80 characters
#181: FILE: arch/x86/kernel/cpu/sgx/ioctl.c:547:
+ if (atomic_read(&encl->flags) & (SGX_ENCL_INITIALIZED | SGX_ENCL_DEAD)) {
WARNING: line over 80 characters
#248: FILE: arch/x86/kernel/cpu/sgx/reclaim.c:386:
+ (atomic_read(&encl->flags) & (SGX_ENCL_DEAD | SGX_ENCL_INITIALIZED)))
total: 0 errors, 2 warnings, 181 lines checked
The one in ioctl.c is ephemeral, i.e. won't exist once the whole series is
squashed, and I felt the code in reclaim.c was more readable by letting
the line poke out a few chars.
That being said, I definitely don't care if you want to tweak the code to
eliminate the warning.
