On Thu, 2019-08-22 at 19:46 +0300, Jarkko Sakkinen wrote: > On Thu, 2019-08-22 at 11:33 +0000, Ayoun, Serge wrote: > > Also replying to Sean. > > Sean is right that never mind the value in secsinfo->flags, HW will reset RWX > > For TCS pages. > > So basically you may not enforce and and could not check those but... The signature depends > > On those flags, so if you put a non-zero flag value, eadd will pass but if you > > compute the signature according to this non zero value then you will have > > a delta between ur signature and HW's signature: einit will fail. > > So this is tricky and more a usability issue. > > I vote for checking the flag is zeroed. > > As I responded to Sean that as long as the ioctl does not adjust > prot bits I'm cool with any sane solution. What do you think of > requiring at minimum RW? > > Doing that kind of adjusting is just doing fixup's for corrupted > data from the user space. Kind of missed your comment about EINIT in rush! A valid point and good catch. I still think my 2nd proposal would be more appropriate than this patch. Signatures will work and we don't need special cases anywhere. /Jarkko
