On Thu, Aug 22, 2019 at 03:56:43PM +0300, Jarkko Sakkinen wrote: > On Mon, Aug 12, 2019 at 06:12:48PM -0700, Sean Christopherson wrote: > > Set SGX_ENCL_PAGE_TCS when encl_page->desc is initialized in > > sgx_encl_page_alloc() to improve readability, and so that the code > > isn't affected when the bulk of __sgx_encl_add_page() is rewritten > > to remove the EADD worker in a future patch. > > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > I don't mean to be impolite but this change only decreases readability, > and in no possible way improves it. Clear semantics and such things > improve readability No worries, it's not the first time my interpretation of what's readable has deviated from the norm :-)