On Mon, Aug 12, 2019 at 06:12:46PM -0700, Sean Christopherson wrote: > Reject the EADD ioctl() if the source address provided by userspace is > not page aligned. Page alignment is required by hardware, but this is > not enforced on userspace as the kernel first copies the source page to > an internal (page aligned) buffer. Require the userspace address to be > page aligned in preparation for reworking EADD to directly consume the > userspace address. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> I missed that there was this change. For most, supporting a fast path does make sense. Removing slow path needs to be brought up separately in the patch set review. Even if this is still a patch set, bundling major shifts to semantics like this is against my maintainer ethics. I hope you get my point of view here. /Jarkko