On Wed, Aug 07, 2019 at 05:12:48PM -0700, Sean Christopherson wrote: > Reject the EADD ioctl() if the source address provided by userspace is > not page aligned. Page alignment is required by hardware, but this is > not enforced on userspace as the kernel first copies the source page to > an internal (page aligned) buffer. Require the userspace address to be > page aligned so that the driver can, in the future, directly consume the > userspace address via EADD without breaking backwards compatibility, > e.g. to avoid the overhead of alloc+memcpy. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> Not sure about this. Why not just implement a fast path when the address is aligned (in future)? /Jarkko
