On Sat, 2019-07-13 at 18:10 +0300, Jarkko Sakkinen wrote: > On Fri, 2019-07-12 at 23:51 -0700, Cedric Xing wrote: > > The original x86/sgx/Makefile didn't work when "x86/sgx" was specified as the > > test target, nor did it work with "run_tests" as the make target. Yet another > > problem was that it breaks 32-bit only build. This patch fixes those problems, > > along with adjustments to compiler/linker options and simplifications to the > > build rules. > > > > Signed-off-by: Cedric Xing <cedric.xing@xxxxxxxxx> > > You must split this in quite a few separate patches: > > 1. One for each fix. > 2. At least one patch for each change in compiler and linker options with a > commit message clearly expalaining why the change was made. > 3. One for each simplification. > > We don't support 32-bit build: > > config INTEL_SGX > bool "Intel SGX core functionality" > depends on X86_64 && CPU_SUP_INTEL This is not to say that changes suck. This just in "unreviewable" state as far as the kernel processes go... /Jarkko
