On Mon, 2019-06-17 at 15:24 -0700, Sean Christopherson wrote: > + __u32 flags; This should be changed to secinfo_flags_mask containing a mask of the allowed bits for the secinfo flags because of two obvious reasons: 1. Protection flags are used mainly with syscalls and contain also other things than just the permissions that do not apply in this context. 2. Having a mask for all secinfo flags is more future proof. With the protection flags you end up reserving bits forever for things that we will never have any use for (e.g. PROT_SEM). Looking the change you convert 'flags' (wondering why it isn't called 'prot') to VM flags, which means that you essentially gain absolutely nothing and loose some potential versatility as a side-effect by doing that. /Jarkko
