On Wed, Jun 5, 2019 at 12:59 PM Dave Hansen <dave.hansen@xxxxxxxxx> wrote: > > On 6/5/19 12:48 PM, Sean Christopherson wrote: > > struct sgx_enclave_add_region { > > __u64 addr; > > @@ -51,7 +52,8 @@ struct sgx_enclave_add_region { > > __u64 secinfo; > > __u32 flags; > > __u16 mrmask; > > -} __attribute__((__packed__)); > > + __u16 reserved; > > +}; > > Without __packed__ do we have strong enough guarantees from the compiler > for a stable ABI? We rely on this kind of thing for uapi on a regular basis, so I sure hope so.