On Tue, Mar 26, 2019 at 03:26:50PM +0200, Jarkko Sakkinen wrote:
> On Thu, Mar 21, 2019 at 05:51:11PM +0200, Jarkko Sakkinen wrote:
> > > Yuck. If we remove the driver specific Makefile then we can eliminate
> > > the "../" prefix here. E.g. in the main SGX Makefile:
> > >
> > > obj-$(CONFIG_INTEL_SGX_DRIVER) += driver/main.o driver/ioctl.o
> >
> > I think this is a great idea.
>
> On a 2nd thought not gonna do anything to that because it would
> require to move driver.h and it is cleaner to keep all the driver
> files in the same directory (and separated from the core).
What about collapsing driver/*.c into driver.c and moving driver.{c,h}
to the root sgx directory? The bulk of driver/main.c is securityfs
and platform driver code, e.g. has a good chance of going away entirely
or being moved out of the "driver". At that point there probably isn't
a strong reason to have driver/main.c and driver/ioctl.c.
