On Mon, Apr 8, 2024, at 17:41, Ilpo Järvinen wrote: > On Mon, 8 Apr 2024, Niklas Schnelle wrote: >> On Mon, 2024-04-08 at 12:54 +0300, Ilpo Järvinen wrote: >> > On Fri, 5 Apr 2024, Niklas Schnelle wrote: >> ---8<--- >> > > diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig >> > > index 47ff50763c04..54bf98869abf 100644 >> > > --- a/drivers/tty/serial/8250/Kconfig >> > > +++ b/drivers/tty/serial/8250/Kconfig >> > > @@ -6,7 +6,6 @@ >> > > >> > > config SERIAL_8250 >> > > tristate "8250/16550 and compatible serial support" >> > > - depends on !S390 >> > >> > Why? Your changelogs gives zero insight on this change. >> >> I used this for compile testing since I build on s390 natively and this >> would have hidden the missing HAS_IOPORT dependencies I'm pretty sure >> it was added because of the I/O port problem too. I'll either add to >> the commit description that it is no longer needed or drop this. Any >> preference? > > Okay, we might never know the reason for sure if that's old enough. > I think the best approach would be to put it into own patch so this > guessimation is limited to a single liner patch instead of it being > hidden among the other clearer cases. >From the description in commit 1598e38c0770 ("serial: forbid 8250 on s390") I would just leave the dependency there. Arnd