Hi, While adding upstream support to a new platform (Mobileye EyeQ5[1]) that uses the AMBA PL011 driver, I took some time to look at the PL011 driver and ended up with a few patches that cleanup parts of it. The line-diff is big mostly because of the checkpatch-fixing commits. The driver hadn't received any love for quite some time. See commit messages for more information. We can thank Ilpo Järvinen for the V3 & V4. V4 fixes an inversed if expression bug added in [PATCH V3 6/6]. [1]: https://lore.kernel.org/all/202310050726.GDpZbMDO-lkp@xxxxxxxxx/T/ Have a nice day, Théo Lebrun Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> --- Changes in v4: - Fix reverse if logic bug in [PATCH V3 6/6]. - Link to v3: https://lore.kernel.org/r/20231120-mbly-uart-v3-0-07ae35979f1f@xxxxxxxxxxx Changes in v3: - Replace magic constants in linux/amba/serial.h by FIELD_PREP_CONST calls - Refactor QDF2400 SoC erratum 44 handling out of probe in a new patch - A nit in "unindent pl011_console_get_options function body" - Link to v2: https://lore.kernel.org/r/20231116-mbly-uart-v2-0-863f665ce520@xxxxxxxxxxx Changes in v2: - [PATCH 2]: add #include <linux/bits.h> in include/linux/amba/serial.h as we use the BIT() macro. - Move one whitespace cleanup from [PATCH 4/6] to [PATCH v2 3/5] where it belongs. - Drop [PATCH 6/6]: console will never have a word length of 5 or 6. - Link to v1: https://lore.kernel.org/r/20231026-mbly-uart-v1-0-9258eea297d3@xxxxxxxxxxx --- Théo Lebrun (6): tty: serial: amba: cleanup whitespace tty: serial: amba: Use linux/bits.h macros for constant declarations tty: serial: amba-pl011: cleanup driver tty: serial: amba-pl011: replace TIOCMBIT macros by static functions tty: serial: amba-pl011: unindent pl011_console_get_options function body tty: serial: amba-pl011: factor QDF2400 SoC erratum 44 out of probe drivers/tty/serial/amba-pl011.c | 260 +++++++++++++++++++++------------------- include/linux/amba/serial.h | 257 ++++++++++++++++++++------------------- 2 files changed, 265 insertions(+), 252 deletions(-) --- base-commit: 82251bf0515a7c32121b0e833922708d4dd70da9 change-id: 20231023-mbly-uart-afcacbb98f8b Best regards, -- Théo Lebrun <theo.lebrun@xxxxxxxxxxx>