On Tue, Jun 18, 2019 at 4:38 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Jun 13, 2019 at 03:08:24PM -0300, Charles wrote: > > Avoid following compiler warning on uninitialized variable > > > > In file included from ./include/linux/rwsem.h:16:0, > > from ./include/linux/notifier.h:15, > > from ./include/linux/clk.h:17, > > from drivers/tty/serial/sh-sci.c:24: > > drivers/tty/serial/sh-sci.c: In function ‘sci_dma_rx_submit’: > > ./include/linux/spinlock.h:288:3: warning: ‘flags’ may be used > > uninitialized in this function [-Wmaybe-uninitialized] > > _raw_spin_unlock_irqrestore(lock, flags); \ > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > drivers/tty/serial/sh-sci.c:1353:16: note: ‘flags’ was declared here > > unsigned long flags; > > ^~~~~ > > What version of gcc is doing this? It should be smarter than that, > perhaps you should just upgrade. Yep, worked like a charm. I was running gcc 6.3.0, just updated to 8.3.0 and got rid of that warning. Thanks, Greg > > thanks, > > greg k-h -- Charles
