On Mon, Jun 11, 2018 at 2:52 PM, Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote: > Rave-sp behaves differently based on the device variant. > sp->variant = of_device_get_match_data(dev); > + if (!sp->variant) { > + id = serdev_match_id(rave_sp_serdev_id, serdev); I think you may leave the ID table where it is in the code and use link. > + if (id) > + sp->variant = (const struct rave_sp_variant *) > + id->driver_data; > + } Perhaps a helper like it's done for ACPI / OF cases? [device_get_match_data() -> ] of_fwnode_device_get_match_data() acpi_fwnode_device_get_match_data() -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html