Re: [PATCH] serial: mvebu-uart: add suspend/resume support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Sat, 21 Apr 2018 16:07:33 +0200, Miquel Raynal wrote:
> Add suspend and resume hooks to save/restore the registers content
> during S2RAM operation.
> 
> Also save/restore the oversampling rate register (OSAMP) as earlier
> stages already tuned that register to get a precise UART clock.

I am a bit surprised by this OSAMP register that we save/restore but
that we never initialize. Shouldn't Linux be initializing this register
isn't of relying on what has been done by "earlier stages" ?

But that clearly doesn't prevent this patch from being applied, it's a
separate concern.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux