Re: [Regression] tty:serial:imx.c v4.9.88 to v4.9.89 serial can't receive in non-dte-mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, April 19, 2018 12:25 PM, Chris Ruehl wrote:
Hi,

the commit for 4.9.89

index 521a6e4..f575a33 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c

removes the
-        temp |= IMX21_UCR3_RXDMUXSEL ...

and only enable it back if the serial port is in dte_mode at later code

this result in the error that a 'non dte' serial port can't receive, no RXDMUXEL.

The fix is to add IMX21_UCR3_RXDMUXSEL .

--- linux-4.9/drivers/tty/serial/imx.c.orig     2018-04-19 12:19:58.512000000 +0800
+++ linux-4.9/drivers/tty/serial/imx.c  2018-04-19 12:07:26.344000000 +0800
@@ -1316,7 +1316,7 @@
         if (!is_imx1_uart(sport)) {
                 temp = readl(sport->port.membase + UCR3);

-               temp |= UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
+               temp |= IMX21_UCR3_RXDMUXSEL | UCR3_DTRDEN | UCR3_RI | UCR3_DCD;

                 if (sport->dte_mode)
                         /* disable broken interrupts */


Tested on a IMX6DL

Please consider to add this patch for me. I do not have a actual linux-next tree to create a patch-set from git.


Regards
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


I'm sorry for the noise.
Found my problem the
fsl,dte-mode;
is missing in our FDT.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux