Re: [v2, 7/8] tty: serial: qcom_geni_serial: Return IRQ_NONE for spurious interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 09, 2018 at 01:38:40PM -0600, Karthikeyan Ramasubramanian wrote:
> Currently the driver returns IRQ_HANDLED when spurious interrupts happen.
> This is misleading. Fix the behavior by returning IRQ_NONE for spurious
> interrupts.
> 
> Signed-off-by: Karthikeyan Ramasubramanian <kramasub@xxxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/qcom_geni_serial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 801e6eb..e40d4a4 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -633,7 +633,7 @@ static irqreturn_t qcom_geni_serial_isr(int isr, void *dev)
>  	struct qcom_geni_serial_port *port = to_dev_port(uport, uport);
>  
>  	if (uport->suspended)
> -		return IRQ_HANDLED;
> +		return IRQ_NONE;
>  
>  	spin_lock_irqsave(&uport->lock, flags);
>  	m_irq_status = readl_relaxed(uport->membase + SE_GENI_M_IRQ_STATUS);

Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux