Re: [v2, 3/8] tty: serial: qcom_geni_serial: Use min3 to find minimum of 3 values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 09, 2018 at 01:38:36PM -0600, Karthikeyan Ramasubramanian wrote:
> Use min3 helper to calculate the minimum value of 3 variables.
> 
> Signed-off-by: Karthikeyan Ramasubramanian <kramasub@xxxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/qcom_geni_serial.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index ae959d6..21e9160 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -586,11 +586,7 @@ static void qcom_geni_serial_handle_tx(struct uart_port *uport)
>  
>  	avail = (port->tx_fifo_depth - port->tx_wm) * port->tx_bytes_pw;
>  	tail = (xmit->tail + port->xmit_size) & (UART_XMIT_SIZE - 1);
> -	if (chunk > (UART_XMIT_SIZE - tail))
> -		chunk = UART_XMIT_SIZE - tail;
> -	if (chunk > avail)
> -		chunk = avail;
> -
> +	chunk = min3((size_t)chunk, UART_XMIT_SIZE - tail, avail);
>  	if (!chunk)
>  		goto out_write_wakeup;

Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux