Re: [PATCH] tty: serial: qcom_geni_serial: Use signed variable to get IRQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/6/2018 3:43 PM, Stephen Boyd wrote:
> Quoting Karthikeyan Ramasubramanian (2018-04-06 13:50:59)
>> The platform_get_irq can return error. Assigning the return value to an
>> unsigned variable and checking it for negative value will always return
>> false.
>>
>> Use an intermediate signed variable to get IRQ information, check for any
>> error and then assign it to 'irq' variable inside uart_port structure.
>>
>> Signed-off-by: Karthikeyan Ramasubramanian <kramasub@xxxxxxxxxxxxxx>
>> ---
> 
> Was this reported by Dan? Add a reported-by tag if so.
> 
> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> 
Yes it was reported by Dan. I will add the reported-by tag.

Regards,
Karthik.
-- 
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux