Hello Karthikeyan Ramasubramanian,
The patch c4f528795d1a: "tty: serial: msm_geni_serial: Add serial
driver support for GENI based QUP" from Mar 14, 2018, leads to the
following static checker warning:
drivers/tty/serial/qcom_geni_serial.c:1065 qcom_geni_serial_probe()
warn: unsigned 'uport->irq' is never less than zero.
drivers/tty/serial/qcom_geni_serial.c
1054
1055 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
1056 if (!res)
1057 return -EINVAL;
1058 uport->mapbase = res->start;
1059
1060 port->tx_fifo_depth = DEF_FIFO_DEPTH_WORDS;
1061 port->rx_fifo_depth = DEF_FIFO_DEPTH_WORDS;
1062 port->tx_fifo_width = DEF_FIFO_WIDTH_BITS;
1063
1064 uport->irq = platform_get_irq(pdev, 0);
1065 if (uport->irq < 0) {
^^^^^^^^^^^^^^
This should be signed. I'd fix this but I don't have a cross compiler
set up, sorry...
1066 dev_err(&pdev->dev, "Failed to get IRQ %d\n", uport->irq);
1067 return uport->irq;
1068 }
1069
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
