On Thursday 29 March 2018 04:00 AM, Tony Lindgren wrote: > * Vignesh R <vigneshr@xxxxxx> [180327 12:03]: >> Enable/Clear module level UART wakeup in UART_OMAP_WER register based on >> return value of device_may_wakeup() in .suspend(). This allows >> userspace to use sysfs to control the ability of UART to wakeup the >> system from deep sleep state. Register is restored back in .startup() >> call that happens as part of resume sequence. >> >> With this patch, userspace can control UART wakeup capability via sysfs: >> To enable wakeup capability: >> echo enabled > /sys/class/tty/ttyXX/device/power/wakeup >> For disabling wakeup capability: >> echo disabled > /sys/class/tty/ttyXX/device/power/wakeup > > To avoid confusion, can you please add this to the description: > > Note that the UART wakeup events configured in the 8250 hardware only > work for idle modes that do not cut off power for the UART. For deeper > idle states, dedicated padconf wakeirqs must be used. Or in some cases > the UART RX pin can be remuxed to GPIO input if the GPIO block stays > powered. > That makes sense, I will add it to patch description in v2. > I tested this briefly and the dedicated wakeirqs still work for me, > so from that point of view: > > Tested-by: Tony Lindgren <tony@xxxxxxxxxxx> Thanks for testing! -- Regards Vignesh -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html