On Wed, Mar 21, 2018 at 10:52:37AM +0800, Jeremy Kerr wrote:
> This change adds a flag to indicate that a UART is has an external means
> of synchronising its FIFO, without needing CTSRTS or XON/XOFF.
>
> This allows us to use the throttle/unthrottle callbacks, without having
> to claim other methods of flow control.
>
> Signed-off-by: Jeremy Kerr <jk@xxxxxxxxxx>
> ---
> drivers/tty/serial/serial_core.c | 4 ++--
> include/linux/serial_core.h | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index f534a40aebde..8f3dfc8b5307 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -678,7 +678,7 @@ static void uart_throttle(struct tty_struct *tty)
> if (C_CRTSCTS(tty))
> mask |= UPSTAT_AUTORTS;
>
> - if (port->status & mask) {
> + if (port->status & (mask | UPSTAT_SYNC_FIFO)) {
> port->ops->throttle(port);
> mask &= ~port->status;
> }
Why not just set mask to UPSTAT_SYNC_FIFO at the top of this function?
> @@ -707,7 +707,7 @@ static void uart_unthrottle(struct tty_struct *tty)
> if (C_CRTSCTS(tty))
> mask |= UPSTAT_AUTORTS;
>
> - if (port->status & mask) {
> + if (port->status & (mask | UPSTAT_SYNC_FIFO)) {
> port->ops->unthrottle(port);
> mask &= ~port->status;
> }
Same here. Would make it a bit more obvious (at least to me...)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
