Re: [PATCH] serial: 8250_dw: Improve dw8250_tx_wait_empty implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 08, 2018 at 04:35:07PM +1300, Joshua Scott wrote:
> The previous implementation has had a detrimental effect on devices using
> high bitrates (bluetooth), as the fifo being non-empty for a single check
> would result in a 10 µs delay.
> 
> This patch updates the code such that it will allow 1000 retries to fail
> before delaying by 1 µs for the remaining retry limit.
> 
> In addition, the maximum number of retries has been increased, both to
> cover the decreased delay length, and to cover a new worst-case seen on
> the Armada 385 SoC. "dmesg ; resize", filling the buffer with text to
> output before reconfiguring, required 13 ms to empty the buffer and avoid
> losing characters.
> ---
>  drivers/tty/serial/8250/8250_dw.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

No signed-off-by :(

This conflicts with Andy's patch, so I'm dropping both from my patch
queue until you both work this out...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux