10 microseconds is a time when 4 characters at speed of 4 Mbps are able to go to the peer. 4 characters is also a condition to generate Rx timeout interrupt on the receiver's side. This is not good and might decrease a throughput and increase a load on the CPU on the remote side. Remove long delay completely. There is no delay in dw8250_check_lsr() either, assuming we are fine w/o it on lower speeds. Cc: Joshua Scott <joshua.scott@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> --- drivers/tty/serial/8250/8250_dw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index 4ad67707a2cd..da337bf453b6 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -130,7 +130,6 @@ static void dw8250_tx_wait_empty(struct uart_port *p) if (lsr & UART_LSR_TEMT) break; - udelay (10); } } -- 2.16.1 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
