Re: [PATCH] serial: imx: Only wakeup via RTSDEN bit if the system has RTS/CTS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabio,

Thus wrote Fabio Estevam (festevam@xxxxxxxxx):

> > Would it make sense to clear UCR1_RTSDEN explicitly if
> > sport->have_rtscts is false?

> I don' think this is needed as UCR1_RTSDEN is only set if
> sport->have_rtscts is true inside imx_startup():

you're right. We can safely assume that bits have the default value
unless our driver modifies them. Therefore,

Reviewed-by: Martin Kaiser <martin@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux