Hi Damian,
The Lenovo T500 is, I believe, based on an Intel Core 2 Duo processor,
so this code should not even be relevant since it's specific to i.MX6
SoCs. Also, I've no idea why this trivial patch would have any impact on
suspend/resume behaviour, even on an i.MX6.
Sorry I can't be of more help.
All the best,
Ian Jamison.
On 28/12/17 11:40, Damian Wrobel wrote:
Ian,
I've started to observe freezes (both keyboard and mouse) after resume
operation on Lenovo T500 laptop (100% reproducible) once switched to
use kernel v4.14.5 version.
The last working version was v4.14.4 so I bisected it and here is what
I received:
$ git bisect good
c25bec2de9268122407a3f431dd7d031c06f293d is the first bad commit
commit c25bec2de9268122407a3f431dd7d031c06f293d
Author: Ian Jamison <ian.dev@xxxxxxxxxx>
Date: Thu Sep 21 10:13:12 2017 +0200
serial: imx: Update cached mctrl value when changing RTS
[ Upstream commit a0983c742a5885f82afb282166f83f1d3d8addf4 ]
UART core function uart_update_mctrl relies on a cached value of
modem control lines. This was used but not updated by local RTS
control functions within imx.c. These are used for RS485 line
driver enable signalling. Having an out-of-date value in the cached
mctrl can result in the transmitter being enabled when it shouldn't
be.
Fix this by updating the mctrl value before applying it.
Signed-off-by: Ian Jamison <ian.dev@xxxxxxxxxx>
Origin:
id:8195c96e674517b82a6ff7fe914c7ba0f86e702b.1505375165.git.ian.dev@xxxxxxxxxx
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Tested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Tested-by: Clemens Gruber <clemens.gruber@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
:040000 040000 a33a5c2758354c7c381ae9257fb42c443f5f3505
e54d5d062793d26464ace91b42c53da686812a34 M drivers
For completeness please find the whole bisection log:
$ git bisect log
git bisect start
# bad: [64138f0adb25ca8f34baa57af33260b05efe2874] Linux 4.14.5
git bisect bad 64138f0adb25ca8f34baa57af33260b05efe2874
# good: [51a2a68fde2035887c0d74aee1c9569c691dfd61] Linux 4.14.4
git bisect good 51a2a68fde2035887c0d74aee1c9569c691dfd61
# good: [5715de464ac8ef97fdc0daacd41ac35dcd412e2f] kprobes: Use
synchronize_rcu_tasks() for optprobe with CONFIG_PREEMPT=y
git bisect good 5715de464ac8ef97fdc0daacd41ac35dcd412e2f
# bad: [a9f359f24ce70a291997b3644aeead56d0c44cd6] s390/ptrace: fix
guarded storage regset handling
git bisect bad a9f359f24ce70a291997b3644aeead56d0c44cd6
# good: [9e99614575b9f1e66249729878a415b9b6659ee7] usb: xhci: Return
error when host is dead in xhci_disable_slot()
git bisect good 9e99614575b9f1e66249729878a415b9b6659ee7
# bad: [9093d8bc530402a7d7651be40dd53b0b97a813af] staging:
fsl-mc/dpio: Fix incorrect comparison
git bisect bad 9093d8bc530402a7d7651be40dd53b0b97a813af
# good: [25aafb3061f64099e379dfb24e394b07f3f93b38] serial: sh-sci:
suppress warning for ports without dma channels
git bisect good 25aafb3061f64099e379dfb24e394b07f3f93b38
# bad: [c25bec2de9268122407a3f431dd7d031c06f293d] serial: imx: Update
cached mctrl value when changing RTS
git bisect bad c25bec2de9268122407a3f431dd7d031c06f293d
# good: [87837b102c0630fd559a412f6fa48c8e9710755c] usbip: tools:
Install all headers needed for libusbip development
git bisect good 87837b102c0630fd559a412f6fa48c8e9710755c
# first bad commit: [c25bec2de9268122407a3f431dd7d031c06f293d] serial:
imx: Update cached mctrl value when changing RTS
Once reverting aforementioned patch on top of v4.14.9 I was able to
resume/suspend without any issue.
Could you please confirm that this patch might have such an impact on
suspend/resume cycle?
If so, could this be fixed/reverted? If you need some more information
please let me know I'll be happy to provide it.
--
Regards,
Damian
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
