Tue, Dec 26, 2017 at 12:09:08AM CET, f.fainelli@xxxxxxxxx wrote: >Le 12/25/17 à 03:53, Oleksandr Shamray a écrit : [...] >[snip] > >> + >> +void *jtag_priv(struct jtag *jtag) >> +{ >> + return jtag->priv; >> +} >> +EXPORT_SYMBOL_GPL(jtag_priv); > >Can't you just create a static inline function in the public header for >that? This is usually what subsystems do, I can understand why you would >not want to expose struct jtag to other parts of the kernel, but still, >this looks ugly, so maybe consider splitting the header between provider >and consumer? Other subsystems expose the struct. Here, it is intentional to don't expose the struct, that's why we have this helper. What is ugly about that? :) -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html