2017-11-27 22:30 GMT+08:00 Arnd Bergmann <arnd@xxxxxxxx>: > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu <green.hu@xxxxxxxxx> wrote: >> @@ -0,0 +1,55 @@ >> +/dts-v1/; >> +/ { >> + compatible = "nds32 ae3xx"; > > The compatible string doesn't seem to match the binding, it should always have > vendor prefix. Sorry I forgot to check this. I will provide a document in bindings like "Documentation/devicetree/bindings/nds32/andestech-boards". >> + #address-cells = <1>; >> + #size-cells = <1>; >> + interrupt-parent = <&intc>; >> + >> + chosen { >> + bootargs = "earlycon console=ttyS0,38400n8 debug loglevel=7"; >> + stdout-path = &serial0; >> + }; > > I would drop the bootargs here, this is something that should be set by the > bootloader and is up to the user. Thanks I will drop it in the next version patch. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html