Re: [PATCH v2] serial driver for IMX: support RS485 config from device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Michal,

> +	if (of_property_read_u32_array(np, "rs485-rts-delay",
> +		rs485_delay, 2) == 0) {

IMHO broken indention. The line above should be indented differently
than the body of the if, preferably to the opening (.

> @@ -2112,8 +2144,6 @@ static int serial_imx_probe(struct platform_device *pdev)
>  	sport->port.fifosize = 32;
>  	sport->port.ops = &imx_pops;
>  	sport->port.rs485_config = imx_rs485_config;
> -	sport->port.rs485.flags =
> -		SER_RS485_RTS_ON_SEND | SER_RS485_RX_DURING_TX;

This patch doesn't apply to next, commit
8b25deb18ba3f9b1af1ff9395b8de2bdb9d9fdbf there already improves the
situation and that one should also make obvious that you should better
improve of_get_rs485_mode instead of the imx driver.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux